fix wrapper constructor in ErrorAnalysisManager and RAIVisionInsights load call for RAI Vision Dashboard #2560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
force-pushed
the
ilmat/fix-ea-vision-load-wrapper
branch
from
74e13c5
to
1e14a9a
Compare
1 similar comment
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2560 +/- ##
==========================================
- Coverage 78.61% 78.19% -0.43%
==========================================
Files 36 36
Lines 2619 2628 +9
==========================================
- Hits 2059 2055 -4
- Misses 560 573 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tongyu-microsoft
approved these changes
Apr 26, 2024
… load call for RAI Vision Dashboard
imatiach-msft
force-pushed
the
ilmat/fix-ea-vision-load-wrapper
branch
from
1e14a9a
to
f584557
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix customer reported issue where RAIVisionInsights is not able to load a pytorch model, thus the RAI Vision component is able to run but there is no dynamic functionality for the dashboard. The error is only happening for torchvision models because they are evaluated with calls to predict function in ml-wrappers. However, the load call does not setup the model in a similar way to the init method, hence the predict call fails, and the dashboard fails to load. This PR fixes the wrap_model setup and adds a test case to validate dashboard can be saved and reloaded for torchvision models.
The error message is specifically:
Checklist