Flyout Bounding Box legend & accessibility fixes #2497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Advitya17
requested review from
imatiach-msft,
gaugup,
tongyu-microsoft,
xuke444,
RubyZ10 and
vinuthakaranth
as code owners
imatiach-msft
approved these changes
Jan 19, 2024
libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/FlyoutObjectDetection.tsx
Outdated
Show resolved
Hide resolved
libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/FlyoutObjectDetection.tsx
Outdated
Show resolved
Hide resolved
1 similar comment
Advitya17
changed the title
imatiach-msft
approved these changes
Jan 22, 2024
…olbox into agemawat/bb_legend
1 similar comment
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added legend for bounding boxes as per customer ask:
This pull request includes updates to improve the functionality and user interface of the codebase. The most important changes include adding a label and combo box for object selection in the
FlyoutObjectDetectioncomponent and renaming a key in theen.jsonfile.User interface improvements:
libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/FlyoutObjectDetection.tsx: Updated theFlyoutObjectDetectioncomponent to include a label and a combo box for object selection, as well as colored squares with text labels indicating the selected objects. The component's theme was also used to determine the colors of the squares. [1] [2] [3] [4]Localization improvement:
libs/localization/src/lib/en.json: Renamed the keyobjectSelecttoobjectSelectionLabelin theen.jsonfile.GitHub Chat Prompt
Response snippet:
Accessibility prompts:
Checklist