Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong metrics count missing in vision explorer of RAI Vision dashboard for object detection #2495

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

imatiach-msft
Copy link
Contributor

Description

fix wrong metrics count missing in vision explorer of RAI Vision dashboard for object detection

Several customers are seeing the wrong metrics count missing in RAI Vision dashboard - this was tracked down to extra whitespace added in the generate_od_error_labels methods for linting:

            rendered_labels[_AGGREGATE_LABEL] = \
                f"{sum(image_labels[_CORRECT].values())} {_CORRECT}, \
                  {sum(image_labels[_INCORRECT].values())} \
                  {_INCORRECT}"

The generated json file then had all of this whitespace for incorrect labels:
image

This extra whitespace at the start of the line caused parsing errors later in the UI code:

image

This PR fixes the issue and also adds some validation checks in the code.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@imatiach-msft imatiach-msft force-pushed the ilmat/fix-wrong-labels-count-missing branch 2 times, most recently from 259c169 to ffede21 Compare January 18, 2024 22:53
2 similar comments
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bee87b5) 88.84% compared to head (ffede21) 78.01%.

Files Patch % Lines
...i_vision/responsibleai_vision/utils/image_utils.py 97.14% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2495       +/-   ##
===========================================
- Coverage   88.84%   78.01%   -10.84%     
===========================================
  Files         134       14      -120     
  Lines        7737     1360     -6377     
===========================================
- Hits         6874     1061     -5813     
+ Misses        863      299      -564     
Flag Coverage Δ
unittests 78.01% <97.14%> (-10.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imatiach-msft imatiach-msft merged commit 946115b into main Jan 19, 2024
97 checks passed
@imatiach-msft imatiach-msft deleted the ilmat/fix-wrong-labels-count-missing branch January 19, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants