Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move missing value validations before unique value validations #2228

Merged
merged 4 commits into from
Aug 11, 2023

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Aug 9, 2023

Description

The np.unique() call downstream will fail in case of missing values in data. So doing the missing value validation up front.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2023

Codecov Report

Merging #2228 (a4fe8ea) into main (9ed4a86) will increase coverage by 4.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2228      +/-   ##
==========================================
+ Coverage   88.09%   92.26%   +4.16%     
==========================================
  Files         129      103      -26     
  Lines        7334     5157    -2177     
==========================================
- Hits         6461     4758    -1703     
+ Misses        873      399     -474     
Flag Coverage Δ
unittests 92.26% <100.00%> (+4.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...sibleai/responsibleai/rai_insights/rai_insights.py 87.74% <100.00%> (ø)

... and 26 files with indirect coverage changes

@gaugup gaugup enabled auto-merge (squash) August 10, 2023 18:32
@gaugup gaugup disabled auto-merge August 11, 2023 17:08
@gaugup gaugup merged commit cd2502a into main Aug 11, 2023
138 of 140 checks passed
@gaugup gaugup deleted the gaugup/MoveValidations branch August 11, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants