-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move missing value validations before unique value validations #2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaurav Gupta <[email protected]>
gaugup
requested review from
imatiach-msft,
xuke444,
kicha0,
RubyZ10,
vinuthakaranth,
tongyu-microsoft and
hawestra
as code owners
August 9, 2023 20:38
Codecov Report
@@ Coverage Diff @@
## main #2228 +/- ##
==========================================
+ Coverage 88.09% 92.26% +4.16%
==========================================
Files 129 103 -26
Lines 7334 5157 -2177
==========================================
- Hits 6461 4758 -1703
+ Misses 873 399 -474
Flags with carried forward coverage won't be shown. Click here to find out more.
|
romanlutz
approved these changes
Aug 10, 2023
hawestra
approved these changes
Aug 10, 2023
imatiach-msft
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The np.unique() call downstream will fail in case of missing values in data. So doing the missing value validation up front.
Checklist