-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for custom app fonts #1828
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform: iOS
This affects iOS
platform: macOS
This affects macOS
labels
Feb 8, 2024
tido64
requested review from
Saadnajmi,
arazabishov,
sweggersen and
kelset
as code owners
February 8, 2024 12:59
kelset
reviewed
Feb 12, 2024
kelset
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and we can
the lowercase thing for Android can be handled as a follow up if needed
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
platform: Android
This affects Android
platform: iOS
This affects iOS
platform: macOS
This affects macOS
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for custom app fonts.
Resolves #1506.
Resolves #1185.
Resolves #1813.
Platforms affected
Test plan
example/dist
)app.json
(an entry for every target platform):Build the example app as usual. Remember that every time you make changes to
app.json
, you need to re-runpod install
.Verify that fonts are copied/registered:
example/android/app/build/generated/rncli/src/main/assets/fonts
example/node_modules/.generated/ios/Info.plist
example/node_modules/.generated/macos/Info.plist
Screenshots