-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syntax highlighting for functions, variables and numbers #2088
Conversation
I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer. @microsoft-github-policy-service agree |
Thanks for the contribution, @Morcifer! One idea I had after looking at your screenshots: would it be possible to use the presence of the |
It's definitely possible (see latest commit): Though it still treats the attributes inside the parentheses of the Config as variables... I think it might be simpler and probably more future-proof to just make a Config-specific rule, rather than to figure out how to disable that one. |
I think the items inside the parens of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement, thank you!
Supports syntax highlighting for:
See issue #1950.
The change for function calls also applies to operation definitions and to attributes (see bigger example below).
The change for variables also applies to attributes and to imports.
I might be nice to make attributes and imports get their own designated rules. I can do them as part of this PR, but I think it might be best to do as a followup issue - because I believe this PR is actually already an improvement for them.
Simple example for the change (from the original issue description):
And a bigger example: