use common extension ID instead of hardcoded one #2064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was there a motivating reason for this change? (i.e. do we ever change it during development, testing, or publishing?) |
|
I was registering a new code action and noticed that we do this inconsistently across other files. If we have a source of truth defined somewhere we might as well use it consistently or not at all. |
swernli
approved these changes
Dec 13, 2024
minestarks
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Personally I preferred the hardcoded versions, since when I'm trying to find a specific command's implementation, usually I try to find the command's user-friendly description in package.json and copy-paste the command name (e.g. "qsharp-vscode.createProject") and search for that in the source.
I don't mind the change though since I'm a fan of consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a drive-by update from my work in #2059. Just wanted it in a separate PR to keep the noise down.
It seems to have triggered some
prettierfixes too.