Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Ising model sample #2060

Merged
merged 7 commits into from
Dec 16, 2024
Merged

Added Ising model sample #2060

merged 7 commits into from
Dec 16, 2024

Conversation

DmitryVasilevsky
Copy link
Contributor

This adds Ising model sample with explanations.

@msoeken
Copy link
Member

msoeken commented Dec 12, 2024

Thanks @DmitryVasilevsky , this would be the third Ising model simulation in the repository alongside https://github.com/microsoft/qsharp/blob/main/samples/estimation/estimation-ising-2D.ipynb and https://github.com/microsoft/qsharp/blob/main/samples/estimation/Dynamics.qs. Maybe we could remove Dynamics.qs in favor of this file and load this new file into estimation-ising-2D.ipynb and only do the explanation and RE in there.

Second, it would be nice, if the the simulation was wrapped into a quantum phase estimation to determine the ground state energy.

@aarthims
Copy link
Contributor

I skimmed through the code and here is one thought I had. @msoeken there is a difference in the estimation-ising-2D and this Ising model simulation in that the former is doing 4th Order Trotterization and this code does 1st Order Trotterization.

As a demo, both do work. However, for utility scale we would want to use 4th order formulas as they minimize errors in the final output.

I do agree that the Dynamics sample and the estimation-ising-2D can be rolled into one.

@DmitryVasilevsky if you can wrap this code with phase estimation (i.e., the simulation will serve as the oracle for phase estimation) as @msoeken suggested, that will be a valuable addition as none of our samples show that at this time.

@DmitryVasilevsky DmitryVasilevsky marked this pull request as ready for review December 16, 2024 09:14
@DmitryVasilevsky
Copy link
Contributor Author

DmitryVasilevsky commented Dec 16, 2024

Thanks @DmitryVasilevsky , this would be the third Ising model simulation in the repository alongside...

Thank you for looking! We discussed this and we would like to have a simple standalone sample of Ising model (a more advanced algorithm) that is suitable for base profile. Changing existing samples and adding phase estimation we may consider later.

@DmitryVasilevsky
Copy link
Contributor Author

As a demo, both do work. However, for utility scale we would want to use 4th order formulas as they minimize errors in the final output.

Thank you for reviewing! We would like to have a standalone simple sample of a more advanced algorithm. Hence this sample. It is suitable for base profile. Changes to other samples and phase estimation for eigenvalue we may consider later; I will open an issue for this.

@DmitryVasilevsky
Copy link
Contributor Author

Added issue #2067

Merged via the queue into main with commit 8f28aa9 Dec 16, 2024
19 checks passed
@DmitryVasilevsky DmitryVasilevsky deleted the dmitryv/ising branch December 16, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants