Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiplayer state #1485

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Fix multiplayer state #1485

merged 1 commit into from
Nov 15, 2024

Conversation

riknoll
Copy link
Member

@riknoll riknoll commented Sep 16, 2024

Fixes microsoft/pxt-arcade#5952

Fixes the player state in the multiplayer extension.

The only actual issue was the check in ensure state (should be this._state.length <= key), but I dislike arbitrarily limiting the number of entries to 255 so I reverted the implementation to that of my original extension which uses an array of objects rather than a sparse array of numbers.

@riknoll riknoll requested review from eanders-ms and a team September 16, 2024 16:50
@abchatra abchatra merged commit 7deed7d into master Nov 15, 2024
4 checks passed
@abchatra abchatra deleted the dev/riknoll/fix-multiplayer-staet branch November 15, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting player custom data doesn't seem to be working
5 participants