Update nrf52 platform.h to support PWM on all pins #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed DEV_PWM_PINS to support all pins on nrf52840 devices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
While developing a MakeCode target for a new custom nrf52840 based board I noticed that the pins on the second port (i.e. P1_0 to P1_31) weren't outputting PWM when analogWrite was called.
To solve this issue I changed
DEV_PWM_PINS(in lib/core---nrf52/platform.h) to0xffffffffffffffffULto support all pins on nrf52840 devices.I haven't got any other nrf52 device to test on so I'm not sure if it will have an effect on other chips but it seems to only be used in the IS_ANALOG_PIN macro so I don't foresee an issue