start on caching

microsoft · Dec 5, 2024 · 2842b34 · 2842b34
1 parent 7c04d0d
commit 2842b34
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/libs/screen/image.cpp b/libs/screen/image.cpp
@@ -870,8 +870,11 @@ bool overlapsWith(Image_ img, Image_ other, int x, int y) {
 //  words byte 4...N: data 1 bit per pixels, high order bit printed first, lines aligned to byte
 
 Image_ convertAndWrap(Buffer buf) {
-    if (isValidImage(buf))
-        return NEW_GC(RefImage, buf);
+    if (isValidImage(buf)) {
+        auto r = NEW_GC(RefImage, buf);
+        r.makeWritable();
+        return r;
+    }
 
     // What follows in this function is mostly dead code, except if people construct image buffers
     // by hand. Probably safe to remove in a year (middle of 2020) or so. When removing, also remove