Fix cross folder dependency (folder reference restriction will be added in a new PR) #990
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily involves refactoring and reorganizing the codebase for better structure and maintainability. The most significant changes are related to the relocation of the
ITelemetry
interface and associated telemetry events, as well as adjustments to import paths due to file relocations.Here are the top five most important changes:
Refactoring of
ITelemetry
Interface and Telemetry Events:The
ITelemetry
interface and associated telemetry events have been moved from thesrc/client/telemetry/
directory to thesrc/common/OneDSLoggerTelemetry/telemetry/
directory. This change affects numerous files across the codebase, with updates to import statements to reflect the new location. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18]Relocation of
OrgChangeNotifier.ts
:The
OrgChangeNotifier.ts
file has been moved from thesrc/common/
directory to thesrc/client/
directory. The import paths within this file have been updated accordingly. [1] [2]Update of Constants:
Several constants have been updated across different files. For instance,
PAC_SUCCESS
has been replaced withSUCCESS
insrc/client/OrgChangeNotifier.ts
, andtelemetryEventNames
has been replaced withdesktopTelemetryEventNames
insrc/client/extension.ts
. [1] [2]Refactoring of Import Paths:
Due to the relocation of various files, import paths have been updated in several files, such as
src/client/extension.ts
,src/client/lib/CliAcquisition.ts
,src/client/lib/GeneratorAcquisition.ts
, and many others. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20]Removal of Unused Imports:
Unused imports have been removed from several files, such as
src/client/extension.ts
andsrc/client/lib/CliAcquisition.ts
, contributing to cleaner, more efficient code. [1] [2]