UserId fix for malformed ID read from auth sessions #974
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE wil consider moving to jsonwebtoken to directly get ID post sync with vscode auth contact point.
This pull request primarily focuses on modifying how user IDs are extracted from account IDs in the
AuthenticationProvider.ts
file. The extraction logic has been changed in four different authentication functions. Instead of usingpop()
to get the last segment of the ID after splitting it by '/', the updated code usesshift()
to get the first segment after splitting the ID by either '.' or '/'.Here are the primary changes:
src/common/services/AuthenticationProvider.ts
-intelligenceAPIAuthentication
function: Updated the extraction ofuserId
fromsession?.account.id
by splitting it with a regular expression and usingshift()
instead ofpop()
.src/common/services/AuthenticationProvider.ts
-dataverseAuthentication
function: Same change as above foruserId
extraction.src/common/services/AuthenticationProvider.ts
-graphClientAuthentication
function: Updated theuserId
extraction logic in the telemetry event.src/common/services/AuthenticationProvider.ts
-bapServiceAuthentication
function: Similar change as above foruserId
extraction in the telemetry event.