Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECS config based copilot disable #920

Merged
merged 4 commits into from
May 2, 2024

Conversation

tyaginidhi
Copy link
Contributor

@tyaginidhi tyaginidhi commented Apr 29, 2024

This pull request includes changes to the PowerPagesCopilot class and related files to handle cases where certain organizations or tenants are disabled. The changes primarily involve checking if the current organization or tenant is included in a list of disabled entities and sending a telemetry event if so. A new utility file copilotUtil.ts has been added to fetch these disabled lists.

Here are the most important changes:

Changes to PowerPagesCopilot class:

  • src/common/copilot/PowerPagesCopilot.ts: Imported getDisabledOrgList and getDisabledTenantList from copilotUtil.ts and added checks to see if the current organization or tenant is included in these lists. If so, a telemetry event is sent and a message is sent to the webview indicating that the service is unavailable. [1] [2] [3]

Changes to telemetry constants:

Addition of new utility file:

  • src/common/copilot/utils/copilotUtil.ts: Added this new file which exports getDisabledOrgList and getDisabledTenantList functions. These functions fetch configuration from ECSFeaturesClient and return lists of disabled organizations or tenants.

Changes to ECSFeaturesClient class:

Addition of new feature config:

@tyaginidhi tyaginidhi marked this pull request as ready for review May 2, 2024 05:29
@tyaginidhi tyaginidhi requested review from a team as code owners May 2, 2024 05:30
@tyaginidhi tyaginidhi merged commit 82b43c8 into main May 2, 2024
4 checks passed
@tyaginidhi tyaginidhi deleted the users/nityagi/ECSCopilotIntegration branch May 2, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants