Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telemetry] Adding x-ms-user-agent in Dataverse calls to check the client surface (Vscode Web/Desktop) #911

Merged
merged 13 commits into from
Apr 23, 2024

Conversation

BidishaMS
Copy link
Contributor

[Telemetry] Adding x-ms-user-agent in Dataverse calls to check the client surface (Vscode Web/Desktop)

@BidishaMS BidishaMS requested review from a team as code owners April 19, 2024 09:12
Copy link
Contributor

@joem-msft joem-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only needing the product version to be added to the x-ms-user-agent header values.
all other comments are recommendations.

src/common/copilot/dataverseMetadata.ts Outdated Show resolved Hide resolved
src/common/copilot/dataverseMetadata.ts Outdated Show resolved Hide resolved
@BidishaMS BidishaMS enabled auto-merge (squash) April 22, 2024 08:43
src/common/Utils.ts Outdated Show resolved Hide resolved
src/common/Utils.ts Outdated Show resolved Hide resolved
src/common/Utils.ts Outdated Show resolved Hide resolved
src/common/Utils.ts Outdated Show resolved Hide resolved
@BidishaMS BidishaMS merged commit a0806b1 into main Apr 23, 2024
4 checks passed
@BidishaMS BidishaMS deleted the users/biddas/UserAgent branch April 23, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants