[Bug Fix] All Instance Removed on Removing Single Instance #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Data instead of _entityId in connectedUsersMap
amitjoshi438
approved these changes
Apr 5, 2024
tyaginidhi
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a critical bug where removing an instance of a user would inadvertently remove all their presence information from both the page-level and collaborative views. The new approach ensures robust, individual tracking of user instances, optimizing real-time collaboration and presence awareness.
Enhancement done: user connection data is directly mapped with user IDs. This mapping allows for the precise removal of specific user connections when they are no longer active, without affecting the presence information of other instances or the overarching user presence.