Populate Website ID in context for desktop extension #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyaginidhi
approved these changes
Feb 20, 2024
BidishaMS
requested changes
Feb 20, 2024
| name: OneDSCollectorEventName.VSCODE_EVENT, | ||
| data: { | ||
| /// Trace info log | ||
| public async traceInfo(eventName: string, eventInfo?: object, measurement?: object) { |
There was a problem hiding this comment.
You can't make traceInfo as async. Neither putting this kind of condition is generic. This method should be as simple as calling 1DSLogger.
There was a problem hiding this comment.
Reading website Id from pac data is an async operation. This can't be put in method populateCommonAttributes function - as this function is itself returning a function & it can't be async by definition - else gives error.
As the requirement is - for every trace being logged websiteId for the activeEditor needs to be logged. This can't be a one time-thing. Will sync offline more on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Populate context object in desktop extension - website ID field to be logged for every trace.
The value for this field will be logged based on the active file in vs code.
If no active file or issue in finding root folder for the data - empty string gets logged as website id.