Action icon buttons code path correction #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitjoshi438
approved these changes
Oct 19, 2023
petrochuk
approved these changes
Oct 19, 2023
tyaginidhi
added a commit
that referenced
this pull request
Oct 19, 2023
tyaginidhi
added a commit
that referenced
this pull request
Oct 19, 2023
#748) * [Power pages Copilo] Updated user prompt telemetry event to include flag for suggested prompt (#744) * getting info about selected code * showing label for selected lines of code * add flag to disable feature * updated responsiveness * code formatting fix * removed log statement * handles empty selections * passing and showing user selected code to copilot * setting fixed vertical height for user code * removed redundant code * added comment * added const for explainCode msg * sending localized string to copilot webview * gpt-tokenizer integration * user prompt with selected code and 'explain' check * showing context cmd only when copilot registered * update handling of empty snippet * updated when clause * moved code to skip in a const * Added telemetry * flag for suggested prompt and user icon update * suggested telemetry * removed comment --------- Co-authored-by: amitjoshi <[email protected]> Co-authored-by: tyaginidhi <[email protected]> * Action icon buttons code path correction (#747) --------- Co-authored-by: amitjoshi438 <[email protected]> Co-authored-by: amitjoshi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in Vscode dev extension testing for css and svg path load in vscode currently which makes verifying this scenario tricky in development.
https://github.com/microsoft/vscode-dev/issues/987
Updating the path to correctly fetch the svg file for action icon display now.