Enhance feedback interaction by adding keyboard accessibility for thumbs up/down buttons #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mbs up/down buttons
priyanshu92
approved these changes
Dec 19, 2024
sanxsth
approved these changes
Dec 19, 2024
amitjoshi438
deleted the
users/amitjoshi/proDevCopilotFeedbackAccessibilityFix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the accessibility of the feedback icons and adds keyboard event handling for better user interaction. The most important changes include adding ARIA labels and tabindex attributes to the feedback icons and implementing a new function to handle keyboard events.
Accessibility improvements:
src/common/copilot/assets/scripts/copilot.js: Addedtabindex="0"andaria-labelattributes to the thumbs up and thumbs down SVG elements to make them accessible via keyboard navigation.Keyboard event handling:
src/common/copilot/assets/scripts/copilot.js: Added an event listener for thekeydownevent to handle keyboard interactions with the feedback icons.src/common/copilot/assets/scripts/copilot.js: Implemented thehandleFeedbackKeydownfunction to handle "Enter" and "Space" key presses for thumbs up and thumbs down interactions.