[@powerpages][5x5] Update Webpage Content and Create Site Records on DV #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 28 commits
November 13, 2024 19:28
…lyFileSystemProvider for site page previews
… CreateSiteHelper to utilize it
…omponents for site creation functionality
…ions and improve readability; add CreateSiteTypes for better type management
…ors in previewSitePagesContent function
…in EditableFileSystemProvider
… user inputs in CreateSiteHelper
…ntOptions interface
…eter for API calls
…tps://github.com/microsoft/powerplatform-vscode into users/amitjoshi/@powerpagesCreateSiteRecordsOnDV
…les for site pages
…itableFileSystemProvider for improved content management
priyanshu92
reviewed
Dec 18, 2024
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| export async function populateSiteRecords(siteName: string, sitePagesList: string[], sitePages: any, orgUrl: string, telemetry: ITelemetry) { | ||
| return vscode.window.withProgress({ |
There was a problem hiding this comment.
Use showProgressWithNotification. You can modify it to pass progress parameter
| } | ||
| const { siteName, siteDescription, sitePages } = await fetchSiteAndPageData(intelligenceAPIEndpointInfo.intelligenceEndpoint, intelligenceApiToken, userPrompt, sessionId, telemetry, stream, orgId, envId, userId); | ||
| const { siteName, siteDescription, sitePages, sitePagesList } = await fetchSiteAndPageData(intelligenceAPIEndpointInfo.intelligenceEndpoint, intelligenceApiToken, userPrompt, sessionId, telemetry, stream, orgId, envId, userId); | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars |
| } | ||
|
|
||
| export enum PowerPagesComponentType { | ||
| PublishingState = '1', |
There was a problem hiding this comment.
Can you add a comment mentioning what are these numbers? Also, I think this is duplicate in SiteComponents.ts
Comment on lines
+5
to
+6
|
|
||
|
|
There was a problem hiding this comment.
nit: extra lines can be removed
| } | ||
|
|
||
| export enum PowerPagesComponentType { | ||
| PublishingState = '1', |
There was a problem hiding this comment.
Can you add a comment mentioning what are these numbers?
Comment on lines
+142
to
+146
| export function base64ToArrayBuffer(base64String: string): ArrayBuffer { | ||
| const binaryString = atob(base64String); | ||
| const bytes = new Uint8Array(binaryString.length).map((_, i) => binaryString.charCodeAt(i)); | ||
| return bytes.buffer; | ||
| } |
There was a problem hiding this comment.
This can be moved to common utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the localization files and the
PowerPagesChatParticipantclass to improve error messaging, site creation, and file system handling. The most important changes include updates to localization strings, modifications to thePowerPagesChatParticipantclass to register a new content provider, and updates to the command execution logic.Localization updates:
l10n/bundle.l10n.jsonandloc/translations-export/vscode-powerplatform.xlf. [1] [2]Enhancements to
PowerPagesChatParticipant:EditableFileSystemProviderto handle file system operations related to site creation.CommandRegistryandPowerPagesChatParticipantclasses to pass theEditableFileSystemProviderto commands. [1] [2]Command execution improvements:
CreateSiteCommandclass to include theEditableFileSystemProviderin its execution logic, enabling better handling of file system operations during site creation. [1] [2]Telemetry updates:
VSCODE_EXTENSION_POPULATE_SITE_RECORDS_STARTandVSCODE_EXTENSION_CREATE_SITE_OPERATION_SUCCESS.These changes collectively enhance the functionality and user experience of the Power Pages site creation process in the VS Code extension.