-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PowerPages][create-site] Preview and Edit Site Page and Command Registration #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lyFileSystemProvider for site page previews
… CreateSiteHelper to utilize it
…omponents for site creation functionality
amitjoshi438
changed the title
Users/amitjoshi/sitePreviewInChat
[PowerPages][create-site] Preview and Edit Site Page and Command Registration
Nov 22, 2024
priyanshu92
reviewed
Nov 22, 2024
src/common/chat-participants/powerpages/commands/create-site/CreateSiteCommand.ts
Show resolved
Hide resolved
src/common/chat-participants/powerpages/commands/create-site/CreateSiteHelper.ts
Outdated
Show resolved
Hide resolved
src/common/chat-participants/powerpages/commands/create-site/CreateSiteHelper.ts
Outdated
Show resolved
Hide resolved
src/common/chat-participants/powerpages/commands/create-site/CreateSiteHelper.ts
Outdated
Show resolved
Hide resolved
…ions and improve readability; add CreateSiteTypes for better type management
sanxsth
approved these changes
Nov 26, 2024
…ors in previewSitePagesContent function
…in EditableFileSystemProvider
priyanshu92
approved these changes
Nov 27, 2024
priyanshu92
approved these changes
Nov 27, 2024
…d CreateSiteTypes
…m/microsoft/powerplatform-vscode into users/amitjoshi/sitePreviewInChat
ashishchoudhary001
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the
PowerPagesChatParticipant
module to enhance the command registration and execution process, introduce a new command for creating sites, and implement a content preview feature. The most important changes are summarized below:Command Registration and Execution Enhancements:
registerCommands
function toChatParticipantUtils.ts
to facilitate command registration.PowerPagesChatParticipant.ts
to utilize the newregisterCommands
function for command registration. [1] [2] [3]New Command Implementation:
CreateSiteCommand
class inCreateSiteCommand.ts
to handle the creation of new Power Pages sites. [1] [2]POWERPAGES_COMMANDS
constant inPowerPagesChatParticipantConstants.ts
to define available commands.Content Preview Feature:
EditableFileSystemProvider
inEditableFileSystemProvider.ts
to manage file content for previewing site pages.CreateSiteHelper.ts
to include apreviewSitePagesContent
function that registers site pages for preview. [1] [2]Constants and Utility Functions:
constants.ts
.CreateSiteConstants.ts
for site creation parameters. [1] [2] [3]These changes collectively improve the functionality and extensibility of the
PowerPagesChatParticipant
module, enabling better command handling and user interaction.