Hook for create site command with nl2page&site #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwani123p
approved these changes
Nov 12, 2024
sanxsth
approved these changes
Nov 13, 2024
sanxsth
reviewed
Nov 13, 2024
src/common/chat-participants/powerpages/commands/create-site/CreateSiteHelper.ts
Outdated
Show resolved
Hide resolved
- Add NL2SITE_GENERATING_SITE constant for generating a new Power Pages site - Update progress message in CreateSiteCommand to use NL2SITE_GENERATING_SITE constant - Remove unnecessary markdown formatting in CreateSiteHelper error handling
tyaginidhi
approved these changes
Nov 13, 2024
src/common/chat-participants/powerpages/commands/create-site/CreateSiteCommand.ts
Outdated
Show resolved
Hide resolved
src/common/chat-participants/powerpages/commands/create-site/CreateSiteCommand.ts
Outdated
Show resolved
Hide resolved
src/common/chat-participants/powerpages/commands/create-site/CreateSiteHelper.ts
Show resolved
Hide resolved
src/common/chat-participants/powerpages/commands/create-site/CreateSiteHelper.ts
Outdated
Show resolved
Hide resolved
…ion' of https://github.com/microsoft/powerplatform-vscode into users/amitjoshi/@powerpagesCreateSiteCommandImplementation
amitjoshi438
deleted the
users/amitjoshi/@powerpagesCreateSiteCommandImplementation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces new functionality for generating Power Pages sites and handling related errors. The most important changes include adding new constants for error messages, implementing a new command for site creation, and defining helper functions to interact with external services.
New constants for error messages and progress updates:
src/common/chat-participants/powerpages/PowerPagesChatParticipantConstants.ts: Added constantsNL2SITE_REQUEST_FAILED,NL2PAGE_GENERATING_WEBPAGES, andNL2PAGE_RESPONSE_FAILEDto handle error messages and progress updates.New command implementation:
src/common/chat-participants/powerpages/commands/create-site/CreateSiteCommand.ts: Implemented theCreateSiteCommandclass to handle the creation of a new Power Pages site, including error handling and progress updates.Helper functions for external service interactions:
src/common/chat-participants/powerpages/commands/create-site/CreateSiteHelper.ts: Added thecreateSitefunction andfetchSiteAndPageDatahelper function to interact with the NL2Site and NL2Page services, handle responses, and manage errors.