Refactor PowerPagesChatParticipant and add CommandRegistry #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanxsth
approved these changes
Oct 23, 2024
tyaginidhi
approved these changes
Oct 24, 2024
amitjoshi438
deleted the
users/amitjoshi/infraForAddingCommandsIn@powerpages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new command registry system to handle command executions within the chat participants module. The key changes include the creation of the
CommandRegistryclass, its integration into thePowerPagesChatParticipantclass, and the implementation of command execution logic.Command Registry System:
src/common/chat-participants/CommandRegistry.ts: Added a newCommandRegistryclass to manage command registrations and retrievals. This includes an interfaceCommandfor defining command execution.Integration with PowerPagesChatParticipant:
src/common/chat-participants/powerpages/PowerPagesChatParticipant.ts: Imported and initialized theCommandRegistryclass. Registered commands and integrated the command execution logic within thePowerPagesChatParticipantclass. [1] [2]Code Cleanup:
src/common/chat-participants/powerpages/PowerPagesChatParticipant.ts: Removed redundant return statement in thePowerPagesChatParticipantclass.