Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECS Initialization in Desktop and @powerpages FCB #1037

Merged
merged 16 commits into from
Sep 10, 2024

Conversation

amitjoshi438
Copy link
Contributor

This pull request introduces several changes to enhance the functionality and telemetry of the Power Pages extension. The most important changes include adding new telemetry keys, updating the chat participant's icon, and introducing a feature gate for enabling GitHub Copilot in Power Pages.

Telemetry Enhancements:

  • Added new telemetry keys EnvIdKey and TenantIdKey to telemetryConstants.ts for capturing additional environment and tenant information. (src/common/OneDSLoggerTelemetry/telemetryConstants.ts)
  • Updated the activate function to include these new telemetry keys and initialize the ECSFeaturesClient with them. (src/client/extension.ts)

Chat Participant Updates:

  • Changed the chat participant's icon from a PNG to an SVG for better scalability. (src/common/chat-participants/powerpages/PowerPagesChatParticipant.ts)
  • Added a check to display a message if GitHub Copilot is not available in the user's region. (src/common/chat-participants/powerpages/PowerPagesChatParticipant.ts)

Feature Gating:

  • Introduced a new feature gate EnablePowerPagesGitHubCopilot to control the availability of GitHub Copilot in Power Pages. (src/common/ecs-features/ecsFeatureGates.ts)
  • Added a utility function isPowerPagesGitHubCopilotEnabled to check the status of the feature gate. (src/common/copilot/utils/copilotUtil.ts)

Minor Changes:

  • Removed the unused when property from the package.json configuration. (package.json)
  • Updated import statements to include new constants and clients. (src/client/extension.ts)

These updates collectively enhance the extension's telemetry capabilities, improve user experience with better assets, and introduce a controlled rollout of new features.

amitjoshi added 11 commits August 1, 2024 17:11
…d Aad ID

This commit initializes the ECSFeaturesClient in the extension.ts file with the environment ID, tenant ID, and Aad ID. It retrieves these values from the pacActiveAuth object and uses them to configure the ECSFeaturesClient. This change ensures that the ECSFeaturesClient is properly initialized with the necessary information for its functionality.

Co-authored-by: amitjoshi <[email protected]>
@amitjoshi438 amitjoshi438 requested review from a team as code owners September 10, 2024 11:52
@amitjoshi438 amitjoshi438 merged commit 0912e35 into main Sep 10, 2024
6 checks passed
@amitjoshi438 amitjoshi438 deleted the user/amitjoshi/EcsFor@Powerpages branch September 10, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants