-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECS Initialization in Desktop and @powerpages FCB #1037
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d Aad ID This commit initializes the ECSFeaturesClient in the extension.ts file with the environment ID, tenant ID, and Aad ID. It retrieves these values from the pacActiveAuth object and uses them to configure the ECSFeaturesClient. This change ensures that the ECSFeaturesClient is properly initialized with the necessary information for its functionality. Co-authored-by: amitjoshi <[email protected]>
…tjoshi/EcsFor@Powerpages
tyaginidhi
reviewed
Sep 10, 2024
tyaginidhi
approved these changes
Sep 10, 2024
…/microsoft/powerplatform-vscode into user/amitjoshi/EcsFor@Powerpages
ritikramuka
approved these changes
Sep 10, 2024
sanxsth
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to enhance the functionality and telemetry of the Power Pages extension. The most important changes include adding new telemetry keys, updating the chat participant's icon, and introducing a feature gate for enabling GitHub Copilot in Power Pages.
Telemetry Enhancements:
EnvIdKey
andTenantIdKey
totelemetryConstants.ts
for capturing additional environment and tenant information. (src/common/OneDSLoggerTelemetry/telemetryConstants.ts
)activate
function to include these new telemetry keys and initialize the ECSFeaturesClient with them. (src/client/extension.ts
)Chat Participant Updates:
src/common/chat-participants/powerpages/PowerPagesChatParticipant.ts
)src/common/chat-participants/powerpages/PowerPagesChatParticipant.ts
)Feature Gating:
EnablePowerPagesGitHubCopilot
to control the availability of GitHub Copilot in Power Pages. (src/common/ecs-features/ecsFeatureGates.ts
)isPowerPagesGitHubCopilotEnabled
to check the status of the feature gate. (src/common/copilot/utils/copilotUtil.ts
)Minor Changes:
when
property from thepackage.json
configuration. (package.json
)src/client/extension.ts
)These updates collectively enhance the extension's telemetry capabilities, improve user experience with better assets, and introduce a controlled rollout of new features.