Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update telemetry events for @powerpages #1032

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Update telemetry events for @powerpages #1032

merged 3 commits into from
Sep 9, 2024

Conversation

amitjoshi438
Copy link
Contributor

This pull request includes changes to update telemetry events. The sendTelemetryEvent function now includes a new property userId in the telemetry data properties. Additionally, the ControlClassIdMap now includes a new constant PowerPagesParticipantDocLink with a link to a Microsoft documentation page. The fetchRelatedFiles and ECSFeaturesClient functions now include logging using the oneDSLoggerWrapper module. Finally, the handleChatParticipantFeedback function now includes logging for thumbs-up and thumbs-down feedback using the oneDSLoggerWrapper module.

@amitjoshi438 amitjoshi438 requested review from a team as code owners September 5, 2024 10:44
gshivi
gshivi reviewed Sep 6, 2024
View reviewed changes
Copy link
Contributor

@gshivi gshivi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please validate once that required events are flowing in telemetry clusters.

@amitjoshi438 amitjoshi438 enabled auto-merge (squash) September 9, 2024 09:23
@amitjoshi438 amitjoshi438 merged commit 16ed7ce into main Sep 9, 2024
6 checks passed
@amitjoshi438 amitjoshi438 deleted the user/amitjoshi/@powerpagesTelemetryUpdatesRuntimeCluster branch September 9, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshivi gshivi gshivi approved these changes

@tyaginidhi tyaginidhi tyaginidhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amitjoshi438 @tyaginidhi @gshivi