Log AadObjectId for desktop extension telemetry #1009
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
src/client
andsrc/common
directories, primarily focusing on adding new authentication functionality and enhancing logging capabilities. The most important changes include importing necessary constants, adding a new type definition, and updating methods to include authentication checks and additional logging information.Authentication Enhancements:
src/client/extension.ts
: Imported theSUCCESS
constant and added a check for active authentication before logging context information. [1] [2]src/client/pac/PacTypes.ts
: Added a new type definitionActiveAuthOutput
andPacAuthWhoOutput
to handle authentication responses.src/client/pac/PacWrapper.ts
: Imported the newPacAuthWhoOutput
type and added a new methodactiveAuth
to fetch active authentication details. [1] [2]Logging Enhancements:
src/common/OneDSLoggerTelemetry/oneDSLogger.ts
: Updated theOneDSLogger
class to log theprincipalObjectId
from the authentication response.