-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add @powerpages feedback telemetry #1000
Merged
amitjoshi438
merged 9 commits into
main
from
users/amitjoshi/@powerpagesFeedbackTelemetry
Aug 26, 2024
Merged
feat: Add @powerpages feedback telemetry #1000
amitjoshi438
merged 9 commits into
main
from
users/amitjoshi/@powerpagesFeedbackTelemetry
Aug 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitjoshi438
commented
Jul 17, 2024
src/common/chat-participants/powerpages/PowerPagesChatParticipant.ts
Outdated
Show resolved
Hide resolved
tyaginidhi
reviewed
Aug 21, 2024
src/common/chat-participants/powerpages/PowerPagesChatParticipantConstants.ts
Outdated
Show resolved
Hide resolved
tyaginidhi
reviewed
Aug 21, 2024
tyaginidhi
approved these changes
Aug 21, 2024
…//github.com/microsoft/powerplatform-vscode into users/amitjoshi/@powerpagesFeedbackTelemetry
ritikramuka
reviewed
Aug 22, 2024
src/common/chat-participants/powerpages/PowerPagesChatParticipantTypes.ts
Show resolved
Hide resolved
src/common/chat-participants/powerpages/PowerPagesChatParticipant.ts
Outdated
Show resolved
Hide resolved
ritikramuka
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on enhancing the chat participant feedback mechanism in the
PowerPagesChatParticipant.ts
file and associated files. The most significant changes include the addition of a feedback handler, the inclusion of metadata in chat results, and the introduction of new constants for feedback scenarios.Feedback Handling:
src/common/chat-participants/powerpages/PowerPagesChatParticipant.ts
: A feedback handlerhandleChatParticipantFeedback
has been added to the classPowerPagesChatParticipant
. This handler is invoked when theonDidReceiveFeedback
event is triggered.Metadata Enhancements:
src/common/chat-participants/powerpages/PowerPagesChatParticipant.ts
: Metadata has been added to the chat results in multiple places in thePowerPagesChatParticipant
class. This metadata includes thecommand
,scenario
, andorgId
fields. [1] [2] [3] [4] [5]src/common/chat-participants/powerpages/PowerPagesChatParticipantTypes.ts
: TheIPowerPagesChatResult
interface has been updated to include the new metadata fields.Constants Addition:
src/common/chat-participants/powerpages/PowerPagesChatParticipantConstants.ts
: New constants have been added for feedback scenarios -VSCODE_EXTENSION_GITHUB_POWER_PAGES_AGENT_SCENARIO_FEEDBACK_THUMBSUP
andVSCODE_EXTENSION_GITHUB_POWER_PAGES_AGENT_SCENARIO_FEEDBACK_THUMBSDOWN
.Utility Functions:
src/common/chat-participants/powerpages/PowerPagesChatParticipantUtils.ts
: ThehandleChatParticipantFeedback
function has been added to handle feedback, sending telemetry events based on the feedback kind.src/common/chat-participants/powerpages/PowerPagesChatParticipant.ts
: ThehandleChatParticipantFeedback
function has been imported fromPowerPagesChatParticipantUtils
.