Skip to content

Commit

Permalink
Merged PR 543517: [Angular Wrapper]: Update powerbi-client version to…
Browse files Browse the repository at this point in the history 
… 2.23.1

Update powerbi-client version and fix failing unit tests

We need to update the tests since we added a check for embedUrl in this [Pull Request 483438](https://dev.azure.com/powerbi/Embedded/_git/powerbi-javascript/pullrequest/483438): JS SDK - embed URL validation
  • Loading branch information
@KotanaSai21
KotanaSai21 committed Apr 15, 2024
1 parent 3cae4cb commit a1735bb
Show file tree
Hide file tree
Showing 8 changed files with 51 additions and 51 deletions.
2 changes: 1 addition & 1 deletion Angular/powerbi-client-angular/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"tag": "beta"
},
"dependencies": {
"powerbi-client": "^2.22.3",
"powerbi-client": "^2.23.1",
"tslib": "^2.1.0"
},
"devDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions ...ient-angular/src/components/powerbi-create-report/powerbi-create-report.component.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ describe('PowerBICreateReportEmbedComponent', () => {
let fixture: ComponentFixture<PowerBICreateReportEmbedComponent>;
const config: IReportCreateConfiguration = {
type: 'create',
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
datasetId: 'fakeId',
};
Expand Down Expand Up @@ -161,7 +161,7 @@ describe('PowerBICreateReportEmbedComponent', () => {
// Embed URL of different create report
const newConfig = {
...config,
embedUrl: 'newFakeUrl'
embedUrl: 'https://app.powerbi.com/newFakeEmbedUrl'
};

// Act
Expand Down
14 changes: 7 additions & 7 deletions ...-angular/src/components/powerbi-dashboard-embed/powerbi-dashboard-embed.component.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ describe('PowerBIDashboardEmbedComponent', () => {
const config = {
type: 'dashboard',
id: 'fakeId',
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};

Expand All @@ -120,7 +120,7 @@ describe('PowerBIDashboardEmbedComponent', () => {
const config = {
type: 'dashboard',
id: 'dashboard',
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
};

// Act
Expand All @@ -142,7 +142,7 @@ describe('PowerBIDashboardEmbedComponent', () => {
const newConfig = {
type: 'dashboard',
id: 'fakeId',
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};

Expand Down Expand Up @@ -178,7 +178,7 @@ describe('PowerBIDashboardEmbedComponent', () => {
const config = {
type: 'dashboard',
id: 'fakeId',
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};

Expand All @@ -188,7 +188,7 @@ describe('PowerBIDashboardEmbedComponent', () => {
fixture.detectChanges();

// Embed URL of different dashboard
config.embedUrl = 'newFakeUrl';
config.embedUrl = 'https://app.powerbi.com/newFakeEmbedUrl';

// Act
component.embedConfig = config;
Expand All @@ -203,14 +203,14 @@ describe('PowerBIDashboardEmbedComponent', () => {
const config = {
type: 'dashboard',
id: 'fakeId',
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};

const newConfig = {
type: 'dashboard',
id: 'fakeId',
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};

Expand Down
18 changes: 9 additions & 9 deletions ...omponents/powerbi-paginated-report-embed/powerbi-paginated-report-embed.component.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ describe('PowerBIPaginatedReportEmbedComponent', () => {
const config = {
type: 'report',
id: 'fakeId',
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};

Expand All @@ -47,7 +47,7 @@ describe('PowerBIPaginatedReportEmbedComponent', () => {
const config = {
type: 'report',
id: 'fakeId',
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};

Expand All @@ -65,7 +65,7 @@ describe('PowerBIPaginatedReportEmbedComponent', () => {
const config = {
type: 'report',
id: 'fakeId',
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};

Expand All @@ -85,7 +85,7 @@ describe('PowerBIPaginatedReportEmbedComponent', () => {
const config = {
type: 'report',
id: 'fakeId',
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};

Expand Down Expand Up @@ -113,7 +113,7 @@ describe('PowerBIPaginatedReportEmbedComponent', () => {
const config = {
type: 'report',
id: 'fakeId',
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};

Expand All @@ -131,7 +131,7 @@ describe('PowerBIPaginatedReportEmbedComponent', () => {
const config = {
type: 'report',
id: 'fakeId',
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};

Expand All @@ -141,7 +141,7 @@ describe('PowerBIPaginatedReportEmbedComponent', () => {
fixture.detectChanges();

// Embed URL of different paginated report
config.embedUrl = 'newFakeUrl';
config.embedUrl = 'https://app.powerbi.com/newFakeEmbedUrl';

// Act
component.embedConfig = config;
Expand All @@ -156,14 +156,14 @@ describe('PowerBIPaginatedReportEmbedComponent', () => {
const config = {
type: 'report',
id: 'fakeId',
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};

const newConfig = {
type: 'report',
id: 'fakeId',
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};

Expand Down
16 changes: 8 additions & 8 deletions ...werbi-client-angular/src/components/powerbi-qna-embed/powerbi-qna-embed.component.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ describe('PowerBIQnaEmbedComponent', () => {
type: 'qna',
datasetIds: ['fakeId'],
id: 'fakeId',
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};

Expand All @@ -126,7 +126,7 @@ describe('PowerBIQnaEmbedComponent', () => {
type: 'qna',
id: 'qna visual',
datasetIds: [],
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
};

// Act
Expand All @@ -150,7 +150,7 @@ describe('PowerBIQnaEmbedComponent', () => {
type: 'qna',
id: 'fakeId',
datasetIds: ['fakeId'],
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};

Expand Down Expand Up @@ -187,7 +187,7 @@ describe('PowerBIQnaEmbedComponent', () => {
type: 'qna',
id: 'fakeId',
datasetIds: ['fakeId'],
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};

Expand All @@ -197,7 +197,7 @@ describe('PowerBIQnaEmbedComponent', () => {
fixture.detectChanges();

// Embed URL of different qna visual
config.embedUrl = 'newFakeUrl';
config.embedUrl = 'https://app.powerbi.com/newFakeEmbedUrl';

// Act
component.embedConfig = config;
Expand All @@ -213,15 +213,15 @@ describe('PowerBIQnaEmbedComponent', () => {
type: 'qna',
id: 'fakeId',
datasetIds: ['fakeId'],
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};

const newConfig = {
type: 'qna',
id: 'fakeId',
datasetIds: ['fakeId'],
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};

Expand Down Expand Up @@ -253,7 +253,7 @@ describe('PowerBIQnaEmbedComponent', () => {
type: 'qna',
id: 'fakeId',
datasetIds: ['fakeId'],
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};
component.embedConfig = config;
Expand Down
20 changes: 10 additions & 10 deletions ...client-angular/src/components/powerbi-report-embed/powerbi-report-embed.component.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ describe('PowerBIReportEmbedComponent', () => {
const config = {
type: 'report',
id: 'fakeId',
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};

Expand All @@ -122,7 +122,7 @@ describe('PowerBIReportEmbedComponent', () => {
const config = {
type: 'report',
id: 'report',
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
};

// Act
Expand All @@ -144,7 +144,7 @@ describe('PowerBIReportEmbedComponent', () => {
const newConfig = {
type: 'report',
id: 'fakeId',
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};

Expand Down Expand Up @@ -180,7 +180,7 @@ describe('PowerBIReportEmbedComponent', () => {
const config = {
type: 'report',
id: 'fakeId',
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};

Expand All @@ -190,7 +190,7 @@ describe('PowerBIReportEmbedComponent', () => {
fixture.detectChanges();

// Embed URL of different report
config.embedUrl = 'newFakeUrl';
config.embedUrl = 'https://app.powerbi.com/newFakeEmbedUrl';

// Act
component.embedConfig = config;
Expand All @@ -205,7 +205,7 @@ describe('PowerBIReportEmbedComponent', () => {
const config = {
type: 'report',
id: 'fakeId',
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};

Expand All @@ -228,7 +228,7 @@ describe('PowerBIReportEmbedComponent', () => {
const config = {
type: 'report',
id: 'fakeId',
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};

Expand All @@ -251,7 +251,7 @@ describe('PowerBIReportEmbedComponent', () => {
const config = {
type: 'report',
id: 'fakeId',
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};

Expand All @@ -273,14 +273,14 @@ describe('PowerBIReportEmbedComponent', () => {
const config = {
type: 'report',
id: 'fakeId',
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};

const newConfig = {
type: 'report',
id: 'fakeId',
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};

Expand Down
14 changes: 7 additions & 7 deletions ...rbi-client-angular/src/components/powerbi-tile-embed/powerbi-tile-embed.component.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ describe('PowerBITileEmbedComponent', () => {
dashboardId: 'fakeId',
type: 'tile',
id: 'fakeId',
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};

Expand All @@ -126,7 +126,7 @@ describe('PowerBITileEmbedComponent', () => {
type: 'tile',
id: 'tile',
dashboardId: 'fakeId',
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
};

// Act
Expand All @@ -150,7 +150,7 @@ describe('PowerBITileEmbedComponent', () => {
type: 'tile',
id: 'fakeId',
dashboardId: 'fakeId',
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};

Expand Down Expand Up @@ -187,7 +187,7 @@ describe('PowerBITileEmbedComponent', () => {
type: 'tile',
id: 'fakeId',
dashboardId: 'fakeId',
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};

Expand All @@ -197,7 +197,7 @@ describe('PowerBITileEmbedComponent', () => {
fixture.detectChanges();

// Embed URL of different tile
config.embedUrl = 'newFakeUrl';
config.embedUrl = 'https://app.powerbi.com/newFakeEmbedUrl';

// Act
component.embedConfig = config;
Expand All @@ -213,15 +213,15 @@ describe('PowerBITileEmbedComponent', () => {
type: 'tile',
id: 'fakeId',
dashboardId: 'fakeId',
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};

const newConfig = {
type: 'tile',
id: 'fakeId',
dashboardId: 'fakeId',
embedUrl: 'fakeUrl',
embedUrl: 'https://app.powerbi.com/fakeEmbedUrl',
accessToken: 'fakeToken',
};

Expand Down
Loading

0 comments on commit a1735bb

Please sign in to comment.