Configurable Retry Logic II - Connection Retry #2517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting files. To allow for PR to be created.
* Trying on a new branch b/c I keep getting build failures and I have no idea why... * Adding back retryExec * More * Missing null check * Next to final * Removed mssql-jdbc.properties * Set up should start fresh + remove passwords to pass on pipeline * Minor cleanup * Minor cleanup * Another missing null check * Fix for timeout tests * Added timing tests + test comments * Formatting * Added a multiple rules test * Trying on a new branch b/c I keep getting build failures and I have no idea why... * More changes * Undo LimitEscapeTest changes * Remove redundant files * Final? * Remove mssql-jdpc.properties file * sync --> lock * Remove problematic test * Since error is unclear, try removing last test * Adding back connection test * I need debugging * Fix for MI * if condition for min time assertion * Leftover debug code, cleanup * Mistaken changes committed * More liberal time windows * Remove connection part * Missed some parts where connection retry was still included. * Forgot one more part * Added (most) PR comment revisions. * Add comments for specified and public facing methods * Added a missing test * More tests * Added more missing tests * Resolve retryCount test failure * Remove eaten exceptions * Removed the file not found exception as we read for file in all cases, not just when using CRL * Added a proper file read * Delete mssql-jdbc.properties * Added more coverage and minor fixes, ready for review again * Fixed read file test * Addressed recent pr comments * Remove double locking * Remove unneeded variable * Revisions after PR review * PR review update * Rename R_AKVURLInvalid as its use is no longer AKV specific * Add back logging * Typo * Removed unneeded comment * Make static variables thread-safe * Timing * JavaDoc cleanup.
…ting files. To allow for PR to be created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2nd part of CRL