-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature flags for static builds #4691
Conversation
Could you update |
I've added it in cargo.yml. Is this Ok? |
Looks like macOS fails to build static. |
I've add framework linking for MacOS. Could you rerun cargo.yaml? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4691 +/- ##
==========================================
+ Coverage 86.81% 86.86% +0.04%
==========================================
Files 56 56
Lines 17361 17363 +2
==========================================
+ Hits 15072 15082 +10
+ Misses 2289 2281 -8 ☔ View full report in Codecov by Sentry. |
Seeing some Ubuntu failures:
|
I've added libnuma linking for Linux. |
Description
This pull request includes changes to add support for static linking. The most important changes include adding a new feature "static" to
Cargo.toml
and modifying the build script to handle static builds.Testing
cargo test --features static
Documentation
No