Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JIT compilation to replace relative path ../src with full URL to prepare for docfx #3909

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

ProjectsByJackHe
Copy link
Contributor

Description

In original docs, links were written with relative paths under the assumption that the user was browsing on github. Now that we have DocFx for our site, we need the absolute paths. This PR implements a JIT script to replace all the relative paths with their absolute paths.

Testing

Using CI.

Documentation

N/A

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #3909 (5748fd8) into main (5b005b2) will decrease coverage by 0.39%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 5748fd8 differs from pull request most recent head 5ac0644. Consider uploading reports for the commit 5ac0644 to get more accurate results

@@            Coverage Diff             @@
##             main    #3909      +/-   ##
==========================================
- Coverage   86.86%   86.48%   -0.39%     
==========================================
  Files          56       56              
  Lines       16876    16889      +13     
==========================================
- Hits        14660    14606      -54     
- Misses       2216     2283      +67     

see 14 files with indirect coverage changes

@ProjectsByJackHe ProjectsByJackHe marked this pull request as ready for review October 10, 2023 22:34
@ProjectsByJackHe ProjectsByJackHe requested a review from a team as a code owner October 10, 2023 22:34
@ProjectsByJackHe ProjectsByJackHe merged commit 6903751 into main Oct 10, 2023
380 of 386 checks passed
@ProjectsByJackHe ProjectsByJackHe deleted the jackhe/fix-link branch October 10, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants