New Largest Packet Number check shifted

microsoft · Jan 3, 2025 · 140e052 · 140e052
1 parent d94d218
commit 140e052
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/core/ack_tracker.c b/src/core/ack_tracker.c
@@ -239,7 +239,7 @@ QuicAckTrackerAckPacket(
 
     Tracker->AckElicitingPacketsToAcknowledge++;
 
-    if ((Connection->Send.SendFlags & QUIC_CONN_SEND_FLAG_ACK) || !NewLargestPacketNumber) {
+    if (Connection->Send.SendFlags & QUIC_CONN_SEND_FLAG_ACK) {
         goto Exit; // Already queued to send an ACK, no more work to do.
     }
 
@@ -262,7 +262,8 @@ QuicAckTrackerAckPacket(
     if (AckType == QUIC_ACK_TYPE_ACK_IMMEDIATE ||
         Connection->Settings.MaxAckDelayMs == 0 ||
         (Tracker->AckElicitingPacketsToAcknowledge >= (uint16_t)Connection->PacketTolerance) ||
-        QuicAckTrackerDidHitReorderingThreshold(Tracker, Connection->ReorderingThreshold)) {
+        (NewLargestPacketNumber && 
+        QuicAckTrackerDidHitReorderingThreshold(Tracker, Connection->ReorderingThreshold))) {
         //
         // Send the ACK immediately.
         //