Add utility to download and install navvis test data #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablospe
reviewed
Jun 21, 2024
|
|
||
| print("Downloading NavVis test data...") | ||
|
|
||
| if(os.path.exists(zipFileName)): |
There was a problem hiding this comment.
nit: I would make that this script takes an output folder, and outside you create a temporal directory, something like:
navvis_test_data_path = Path(tempfile.mkdtemp())
Then you avoid check if exists, also you can remove the .gitignore. The idea is not to populate the git repo with untracked files.
There was a problem hiding this comment.
k will come back to this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new release v1.1 provides NavVis test data for download.
Only convenience method
https://github.com/microsoft/lamar-benchmark/releases/tag/v1.1