Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simpler way to type type.py #909

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Simpler way to type type.py #909

merged 1 commit into from
Jul 1, 2021

Conversation

cgravill
Copy link
Contributor

@cgravill cgravill commented Jul 1, 2021 •
edited
Loading

Drop classproperty, just "declare" attributes in advance
alternative from @acl33
#888 (comment)

@cgravill cgravill requested review from awf and acl33 July 1, 2021 12:58
@cgravill cgravill changed the title Drop classproperty, just "declare" attributes in advance Simpler way to type type.py Jul 1, 2021
awf
awf approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@awf awf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I like this

@cgravill cgravill marked this pull request as ready for review July 1, 2021 15:24
@cgravill cgravill merged commit fa69fd2 into master Jul 1, 2021
@cgravill cgravill deleted the cogravil/typetypingtwo branch July 1, 2021 15:25
@awf awf mentioned this pull request Jul 1, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awf awf awf approved these changes

@acl33 acl33 Awaiting requested review from acl33

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgravill @awf