Add thorough test for GMM #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toelli-msft
force-pushed
the
toelli/test_gmm
branch
3 times, most recently
from
b5e09c6
to
f210695
Compare
|
This PR is basically the same thing I did in #152 but for GMM instead of ADBench LSTM. I'm adding a C++ wrapper module for the Knossos-generated code so that it can be loaded in Python and tested against a reference implementation. |
toelli-msft
force-pushed
the
toelli/test_gmm
branch
from
f210695
to
c46cd17
Compare
awf
approved these changes
Nov 21, 2019
because we're not only making MNIST modules!
toelli-msft
force-pushed
the
toelli/test_gmm
branch
from
bc646a2
to
ea20625
Compare
|
I added a few more comments to explain what's going on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.