Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unused strconv import in Go request builder #5920

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

Ndiritu
Copy link
Contributor

@Ndiritu Ndiritu commented Dec 18, 2024

Removes unused strconv import added when an ISODuration type is parsed and updates types to ignore before importing strconv

Unblocks weekly generation build failure where strconv is imported but not used in request builder

@Ndiritu Ndiritu self-assigned this Dec 18, 2024
@Ndiritu Ndiritu requested a review from a team as a code owner December 18, 2024 11:47
@Ndiritu Ndiritu changed the title fix: Add strconv import only for types that strconv can parse to string fix: Unused strconv import in Go request builder Dec 18, 2024
@Ndiritu Ndiritu changed the title fix: Unused strconv import in Go request builder fix: Unused strconv import in Go request builder Dec 18, 2024
@baywet baywet added this to the Kiota v1.22 milestone Dec 18, 2024
@Ndiritu
Copy link
Contributor Author

Ndiritu commented Dec 18, 2024

Successful build on newly generated changes on Graph Go Beta SDK - microsoftgraph/msgraph-beta-sdk-go#489

@Ndiritu Ndiritu merged commit 12abd43 into main Dec 18, 2024
214 checks passed
@Ndiritu Ndiritu deleted the fix/go-unused-import branch December 18, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ✔️
Development

Successfully merging this pull request may close these issues.

2 participants