Fixes inheritance evaluation when a referenced schema in an allOf #5886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5701
In the scenario for generating the models for inheritance, it won't make sense for a schema to inherit from a primitive.
This changes in this PR ensure that the meaningful schemas used by the
IsInheritedare of the object type (if specified) so that generation can be done using models that are part of the code DOM (given that primitives are externally defined, "inheriting" from primitives would also cause failures at later generation stages in the builder)Using the sample in the issue at #5701, the generated model(Order) should have the TraderId property correctly generated as a string as well.