Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: test show plugins and clients #5838

Merged
merged 9 commits into from
Nov 27, 2024
Merged

Task: test show plugins and clients #5838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
59577ad
add new tests
thewahome Nov 27, 2024
32439ed
add yes answer title
thewahome Nov 27, 2024
5cc8719
log content
thewahome Nov 27, 2024
f31a1ba
refined logs
thewahome Nov 27, 2024
5794ff1
logging in execute function
thewahome Nov 27, 2024
23036cf
add delte stub console
thewahome Nov 27, 2024
6672c10
add more logs
thewahome Nov 27, 2024
e205956
change response signature
thewahome Nov 27, 2024
56607e2
remove console logs
thewahome Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions vscode/microsoft-kiota/src/commands/deleteWorkspaceItem/deleteWorkspaceItemCommand.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,16 @@ export class DeleteWorkspaceItemCommand extends Command {

public async execute(workspaceTreeItem: WorkspaceTreeItem): Promise<void> {
const type = workspaceTreeItem.category && isPluginType(workspaceTreeItem.category) ? "plugin" : "client";
const yesAnswer = vscode.l10n.t("Yes");
const yesAnswer: vscode.MessageItem = { title: vscode.l10n.t("Yes") };
const noAnswer: vscode.MessageItem = { title: vscode.l10n.t("No") };

const response = await vscode.window.showWarningMessage(
vscode.l10n.t("Do you want to delete this item?"),
yesAnswer,
vscode.l10n.t("No")
noAnswer
);
if (response === yesAnswer) {

if (response?.title === yesAnswer.title) {
const result = await this.deleteItem(type, workspaceTreeItem);
if (result) {
const isSuccess = result.some(k => k.message.includes('removed successfully'));
Expand Down
12 changes: 7 additions & 5 deletions vscode/microsoft-kiota/src/test/suite/commands/deleteWorkspaceItemCommand.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,18 @@ suite('DeleteWorkspaceItemCommand Tests', () => {
});

test('execute should show success message and refresh workspace on success', async () => {
const deleteItemStub = sinon.stub(command as any, 'deleteItem').resolves([{ message: 'removed successfully' }]);
const showWarningMessageStub = sinon.stub(vscode.window, 'showWarningMessage').resolves({ title: "Yes" });
const yesAnswer: vscode.MessageItem = { title: vscode.l10n.t("Yes") };

const showWarningMessageStub = sinon.stub(vscode.window, 'showWarningMessage').resolves(yesAnswer);
const showInformationMessageStub = sinon.stub(vscode.window, 'showInformationMessage').resolves();
const executeCommandStub = sinon.stub(vscode.commands, 'executeCommand').resolves();
const deleteItemStub = sinon.stub(command as any, 'deleteItem').resolves([{ message: 'removed successfully' }]);

await command.execute(workspaceTreeItem);

assert.strictEqual(showWarningMessageStub.calledOnce, true);
assert.strictEqual(showInformationMessageStub.calledOnce, true);
assert.strictEqual(executeCommandStub.calledWith('kiota.workspace.refresh'), true);
assert.strictEqual(deleteItemStub.calledOnce, true);
assert.strictEqual(showWarningMessageStub.calledOnceWith("Do you want to delete this item?", sinon.match("Yes"), sinon.match("No")), true);
assert.strictEqual(showInformationMessageStub.calledOnceWith('test-item removed successfully.'), true);
assert.strictEqual(executeCommandStub.calledOnceWith('kiota.workspace.refresh'), true);
});
});
Loading