Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: infinite lookup for discriminator #5828

Merged
merged 4 commits into from
Nov 27, 2024
Merged

fix: infinite lookup for discriminator #5828

merged 4 commits into from
Nov 27, 2024

Conversation

baywet
Copy link
Member

@baywet baywet commented Nov 25, 2024

fixes #5771

@baywet baywet requested a review from a team as a code owner November 25, 2024 19:01
@baywet baywet enabled auto-merge November 25, 2024 19:01
@baywet baywet mentioned this pull request Nov 25, 2024
Closed
Ndiritu
Ndiritu reviewed Nov 26, 2024
View reviewed changes
Copy link
Contributor

@Ndiritu Ndiritu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a test case to replicate the failing scenario?

@baywet baywet merged commit 443e2a4 into main Nov 27, 2024
214 checks passed
@baywet baywet deleted the fix/discriminator-infinite-lookup branch November 27, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ndiritu Ndiritu Ndiritu left review comments

@rkodev rkodev rkodev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Status: Done ✔️
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stack overflow exception generating a client
3 participants
@baywet @Ndiritu @rkodev