Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getting rid of unnecessary guid-typescript dependency #5734

Merged
merged 1 commit into from
Nov 7, 2024
Merged

fix: getting rid of unnecessary guid-typescript dependency #5734

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Kiota.Builder/Refiners/TypeScriptRefiner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,6 @@ currentInterface.StartBlock is InterfaceDeclaration interfaceDeclaration &&
}
CrawlTree(currentElement, AliasUsingsWithSameSymbol);
}
private const string GuidPackageName = "guid-typescript";
private const string AbstractionsPackageName = "@microsoft/kiota-abstractions";
// A helper method to check if a parameter is a multipart body
private static bool IsMultipartBody(CodeParameter p) =>
Expand Down Expand Up @@ -840,7 +839,7 @@ private static void CorrectMethodType(CodeMethod currentMethod)
{"Guid", (string.Empty, new CodeUsing {
Name = "Guid",
Declaration = new CodeType {
Name = GuidPackageName,
Name = AbstractionsPackageName,
IsExternal = true,
},
IsErasable = true, // the import is used only for the type, not for the value
Expand Down
Loading