Fix Cyclic Dependencies in Go #5467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkodev
force-pushed
the
fix/go-cyclic-dependencies
branch
from
2c930e1 to
a7c858c
Compare
|
Just checking first, |
|
@andrueastman so this will not break the existing code releases as it only flattens the models when it detects a circular reference. The issue was suggesting flattening the entire package but in this case the solution only flattens packages that have a circular reference https://github.com/microsoft/kiota/blob/fix/go-cyclic-dependencies/src/Kiota.Builder/Refiners/GoRefiner.cs#L289 |
rkodev
force-pushed
the
fix/go-cyclic-dependencies
branch
from
92b94e5 to
6d02976
Compare
baywet
reviewed
Oct 3, 2024
…ta into fix/go-cyclic-dependencies
baywet
previously approved these changes
Oct 4, 2024
andrueastman
reviewed
Oct 7, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2834
Fixes cyclic dependencies by flattening models affected by cyclic depndecies i.e when a cyclic depedency is detected the affected packages will be flattened and migrated to the rot models package.
For example
models -> submodule1 -> submodule2 -> submodule3 -> submodule2
will be flattened by migrating everything under submodule2 to the root models package
Testing: