-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/error message missing #5314
Conversation
Signed-off-by: Vincent Biret <[email protected]>
…ties Signed-off-by: Vincent Biret <[email protected]>
@baywet I made a few changes here. I believe that rather that rather than removing the conflicting errorMessage property as we did in #4930, We should rename it and still keep the primary message property. This way we get to
/// <summary>The primary error message.</summary>
public override string Message { get => MessageEscaped ?? string.Empty; }
/// <summary>The Message property</summary>
#if NETSTANDARD2_1_OR_GREATER || NETCOREAPP3_1_OR_GREATER
#nullable enable
public string? MessageEscaped { get; set; } |
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
@andrueastman thanks for your contribution here. I pushed additional commits for the serialization name and the changelog. Ready for review and merge! |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
fixes #5311
This a PR is a follow up to #4930.
Rather than removing the conflicting errorMessage property, we should rename it and keep the primary message property. The renamed property should then set as
IsPrimaryErrorMessage
so that the derialized information may be propagated up to the Exception/error info.