Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exception with union of nullable types #5281

Merged
merged 5 commits into from
Sep 5, 2024
Merged

Conversation

baywet
Copy link
Member

@baywet baywet commented Aug 30, 2024

fixes #5276

Signed-off-by: Vincent Biret <[email protected]>
@calebkiage
Copy link
Contributor

is this testable?

@baywet
Copy link
Member Author

baywet commented Aug 30, 2024

is this testable?

The author of the issue shared detailed repro. I was running out of time. But you could add a unit test from those if you don't mind please?
(Monday is a public holiday in Canada)

@baywet
Copy link
Member Author

baywet commented Sep 5, 2024

@calebkiage it took me a while to come back to this one, but finally got around to adding a unit test. Good for review.

Copy link

sonarqubecloud bot commented Sep 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
73.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@baywet baywet merged commit 45399c3 into main Sep 5, 2024
208 of 209 checks passed
@baywet baywet deleted the fix/nullable-union branch September 5, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
3 participants