fix: missing ts path parameters

CHANGELOG.md

@@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Fixed shorthand for refresh option in workspace experience. [#5240](https://github.com/microsoft/kiota/issues/5240)
 - Fixed missing type options in help for plugin commands. [#5230](https://github.com/microsoft/kiota/issues/5230)
 - Removed OpenAI plugins generation since the service does not support them anymore.
+- Fixed an issue where TypeScript clients would be missing path parameters. [#5247](https://github.com/microsoft/kiota/issues/5247)
 - Redirect status codes documenting an application/octet-stream content type now generate a stream return type. [#5246](https://github.com/microsoft/kiota/issues/5246)
 - Fixed an issue where models would be missing when they had no properties and a single allOf entry. [#5014](https://github.com/microsoft/kiota/issues/5014)
 - Reverts modification of responses in output openApi file when generating plugins [#4945](https://github.com/microsoft/kiota/issues/4945)

src/Kiota.Builder/CodeDOM/CodeParameter.cs

@@ -79,6 +79,10 @@ public bool Optional
     public CodeDocumentation Documentation { get; set; } = new();
     public string DefaultValue { get; set; } = string.Empty;
     public string SerializationName { get; set; } = string.Empty;
+    public string WireName
+    {
+        get => string.IsNullOrEmpty(SerializationName) ? Name : SerializationName;
+    }
     public DeprecationInformation? Deprecation
     {
         get;

src/Kiota.Builder/Writers/TypeScript/CodeConstantWriter.cs

@@ -34,9 +34,9 @@
         }
     }
 
     private void WriteNavigationMetadataConstant(CodeConstant codeElement, LanguageWriter writer)
     {
         if (codeElement.OriginalCodeElement is not CodeClass codeClass) throw new InvalidOperationException("Original CodeElement cannot be null");
         if (codeElement.Parent is not CodeFile parentCodeFile || parentCodeFile.FindChildByName<CodeInterface>(codeElement.Name.Replace(CodeConstant.NavigationMetadataSuffix, string.Empty, StringComparison.Ordinal), false) is not CodeInterface currentInterface)
             throw new InvalidOperationException("Couldn't find the associated interface for the navigation metadata constant");
         var navigationMethods = codeClass.Methods
@@ -56,7 +56,7 @@
         {
             writer.StartBlock($"{navigationMethod.Name.ToFirstCharacterLowerCase()}: {{");
             var requestBuilderName = navigationMethod.ReturnType.Name.ToFirstCharacterUpperCase();
-            WriteNavigationMetadataEntry(parentNamespace, writer, requestBuilderName, navigationMethod.Parameters.Where(static x => x.Kind is CodeParameterKind.Path or CodeParameterKind.Custom && !string.IsNullOrEmpty(x.SerializationName)).Select(static x => $"\"{x.SerializationName}\"").ToArray());
+            WriteNavigationMetadataEntry(parentNamespace, writer, requestBuilderName, navigationMethod.Parameters.Where(static x => x.Kind is CodeParameterKind.Path or CodeParameterKind.Custom).Select(static x => $"\"{x.WireName}\"").ToArray());
             writer.CloseBlock("},");
         }
         foreach (var navigationProperty in navigationProperties)
@@ -83,7 +83,7 @@
         $"_{original.ToUpperInvariant()}" : // to avoid emitting strings that can't be minified
         original.ToUpperInvariant();
 
     private void WriteRequestsMetadataConstant(CodeConstant codeElement, LanguageWriter writer)
     {
         if (codeElement.OriginalCodeElement is not CodeClass codeClass) throw new InvalidOperationException("Original CodeElement cannot be null");
         if (codeClass.Methods
@@ -155,7 +155,7 @@
             return "\"setContentFromParsable\"";
         return "\"setContentFromScalar\"";
     }
     private string? GetBodySerializer(CodeParameter requestBody)
     {
         if (requestBody.Type is CodeType currentType && (currentType.TypeDefinition is CodeInterface || currentType.Name.Equals("MultipartBody", StringComparison.OrdinalIgnoreCase)))
         {
@@ -199,7 +199,7 @@
         throw new InvalidOperationException($"Unable to find factory method for {targetClassName}");
     }
 
     private string GetSendRequestMethodName(bool isVoid, bool isStream, bool isCollection, bool isPrimitive, bool isEnum)
     {
         if (isVoid)
         {
@@ -219,7 +219,7 @@
         }
     }
 
     private void WriteUriTemplateConstant(CodeConstant codeElement, LanguageWriter writer)
     {
         writer.WriteLine($"export const {codeElement.Name.ToFirstCharacterUpperCase()} = {codeElement.UriTemplate};");
     }