-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always inherit from base class (don't squash) when oneOf ref'd via discriminator #5123
Conversation
… a oneOf discrimintator
… a oneOf discrimintator
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Validated generation with microsoftgraph/msgraph-sdk-dotnet#2615
@pettijohn Any chance you can add an entry to the Changelo file at the repository root as well?
Co-authored-by: Andrew Omondi <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
I did a little bit of cleanup for unused parameters.
Thank you! Looks like @baywet added the changelog entry. |
Resolves #5014