Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always inherit from base class (don't squash) when oneOf ref'd via discriminator #5123

Merged
merged 12 commits into from
Aug 13, 2024

Conversation

pettijohn
Copy link
Contributor

Resolves #5014

@pettijohn pettijohn requested a review from a team as a code owner August 10, 2024 17:53
@pettijohn
Copy link
Contributor Author

@microsoft-github-policy-service agree

Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Validated generation with microsoftgraph/msgraph-sdk-dotnet#2615

@pettijohn Any chance you can add an entry to the Changelo file at the repository root as well?

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!
I did a little bit of cleanup for unused parameters.

@baywet baywet enabled auto-merge August 13, 2024 14:30
@baywet baywet merged commit 4e9a9ab into microsoft:main Aug 13, 2024
208 checks passed
@pettijohn
Copy link
Contributor Author

Thank you! Looks like @baywet added the changelog entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AllOf C# Inheritence
3 participants