Ignore method arguments typechecking in typescript #5095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrueastman
reviewed
Aug 6, 2024
There was a problem hiding this comment.
Thanks for the contribution here @sher
Any chance you can also add changelog entry for the change as well to the changelog file at the repository root?
|
@andrueastman |
andrueastman
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new function to include
ts-ignorecomment to method shape/prototype.Currently, generated TypeScript client code contains methods with unused arguments that are never referenced in the body.
This causes TypeScript typecheck to fail in projects where
tsconfig.jsoncompiler optionnoUnusedLocals: trueis set.Example: Vitejs template tsconfig.json
p.s.: not sure what to test here.