Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing properties in python when no additional properties #5041

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

baywet
Copy link
Member

@baywet baywet commented Jul 30, 2024

fixes #5037
fixes #4643

@baywet baywet requested a review from a team as a code owner July 30, 2024 16:48
@baywet baywet self-assigned this Jul 30, 2024
@baywet baywet enabled auto-merge July 30, 2024 16:48
auto-merge was automatically disabled July 30, 2024 16:52

Pull Request is not mergeable

@baywet baywet marked this pull request as draft July 30, 2024 19:42
@baywet
Copy link
Member Author

baywet commented Jul 30, 2024

some integration tests seem to be failing now, I'll take a look at it tomorrow

@baywet baywet force-pushed the bugfix/missing-properties-python branch from 1d1d28f to a4f05cd Compare August 1, 2024 13:54
@baywet baywet marked this pull request as ready for review August 1, 2024 13:54
@baywet baywet enabled auto-merge August 1, 2024 13:54
Copy link

sonarqubecloud bot commented Aug 1, 2024

auto-merge was automatically disabled August 1, 2024 14:07

Pull Request is not mergeable

@andrueastman andrueastman enabled auto-merge August 1, 2024 14:13
@andrueastman andrueastman merged commit b8e5dc5 into main Aug 1, 2024
207 checks passed
@andrueastman andrueastman deleted the bugfix/missing-properties-python branch August 1, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
2 participants