Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit [GeneratedCode] attribute for C# types #4924

Merged

Conversation

martincostello
Copy link
Contributor

  • Emit [GeneratedCode] attribute for C# types.
  • Ignore MD024 for duplicate headings in CHANGELOG.
  • Fix malformed link syntax in CHANGELOG.

Resolves #4907.

@martincostello martincostello requested a review from a team as a code owner July 2, 2024 13:44
@martincostello martincostello force-pushed the gh-4907-generatedcode-attribute branch from 23d2692 to 7e2c01c Compare July 2, 2024 13:44
martincostello added a commit to martincostello/kiota-experiment that referenced this pull request Jul 2, 2024
@martincostello
Copy link
Contributor Author

FYI this is the diff I get between 1.15 and this PR for a project I've been testing Kiota with: martincostello/kiota-experiment@ffb1bfb

Emit `[GeneratedCode]` attribute for C# types.
Resolves microsoft#4907.
- Ignore MD024 for duplicate headings.
- Fix malformed link syntax.
Use `KiotaVersion.Current()` instead of reflection to render the version for `[GeneratedCode]` to address feedback.
@martincostello martincostello force-pushed the gh-4907-generatedcode-attribute branch from 10532fc to aee7fb3 Compare July 2, 2024 17:24
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution I will let Andrew do a final review and merge things.

@andrueastman andrueastman merged commit f21a8a7 into microsoft:main Jul 3, 2024
206 checks passed
@martincostello martincostello deleted the gh-4907-generatedcode-attribute branch July 3, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emit [GeneratedCode] for C# code generation
4 participants