Fix message log when generating plugins

CHANGELOG.md

@@ -7,20 +7,19 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
-### Changed
-- Implemented partial class model declarations. [4894](https://github.com/microsoft/kiota/issues/4894)
-
 ### Added
 
 ### Changed
 
+- Implemented partial class model declarations. [4894](https://github.com/microsoft/kiota/issues/4894)
 - Fixes bug with model names in Go generated from camel case namespace. [https://github.com/microsoftgraph/msgraph-sdk-go/issues/721]
 - Plugins OpenAPI extensions are only added when generating plugins to reduce the risk of parsing errors. [#4834](https://github.com/microsoft/kiota/issues/4834)
 - TypeScript imports are now using ES6 imports with the .js extension.
 - Remove LINQ usage in generated code.
 - Ensures descriptions are not empty in sliced OpenApi file when generating a plugin.
 - Plugins do not emit parameters anymore. [#4841](https://github.com/microsoft/kiota/issues/4841)
 - References to C# types generated by kiota are prefixed with `global::` to avoid name collisions. [#4796](https://github.com/microsoft/kiota/issues/4796)
+- Dropped `client base url set to` message when generating plugins. [#4905](https://github.com/microsoft/kiota/issues/4905)
 
 ## [1.15.0] - 2024-06-06
 

src/Kiota.Builder/KiotaBuilder.cs

@@ -136,7 +136,7 @@
 #pragma warning restore CA1031
         {
             if (!skipErrorLog)
                 logger.LogCritical("error getting the API manifest: {ExceptionMessage}", ex.Message);
             return null;
         }
     }
@@ -432,7 +432,10 @@
         if (openApiDocument is not null && openApiDocument.GetAPIRootUrl(config.OpenAPIFilePath) is string candidateUrl)
         {
             config.ApiRootUrl = candidateUrl;
-            logger.LogInformation("Client root URL set to {ApiRootUrl}", candidateUrl);
+            if (!config.IsPluginConfiguration)
+            {
+                logger.LogInformation("Client root URL set to {ApiRootUrl}", candidateUrl);
+            }
         }
         else
             logger.LogWarning("No server url found in the OpenAPI document. The base url will need to be set when using the client.");
@@ -692,7 +695,7 @@
         methodToAdd.AddParameter(new CodeParameter
         {
             Name = "rawUrl",
             Type = new CodeType { Name = "string", IsExternal = true },
             Optional = false,
             Documentation = new()
             {
@@ -806,7 +809,7 @@
             IsAsync = false,
             IsStatic = false,
             Documentation = new(new() {
                                 {"TypeName", new CodeType {
                                     IsExternal = false,
                                     TypeDefinition = currentClass,
                                 }
@@ -1048,7 +1051,7 @@
 
         if (!"string".Equals(parameter.Type.Name, StringComparison.OrdinalIgnoreCase) && config.IncludeBackwardCompatible)
         { // adding a second indexer for the string version of the parameter so we keep backward compatibility
             //TODO remove for v2
             var backCompatibleValue = (CodeIndexer)result[0].Clone();
             backCompatibleValue.Name += "-string";
             backCompatibleValue.IndexParameter.Type = DefaultIndexerParameterType;
@@ -1122,15 +1125,15 @@
             var primitiveTypeName = (typeName?.ToLowerInvariant(), format?.ToLowerInvariant()) switch
             {
                 ("string", "base64url") => "base64url",
                 ("file", _) => "binary",
                 ("string", "duration") => "TimeSpan",
                 ("string", "time") => "TimeOnly",
                 ("string", "date") => "DateOnly",
                 ("string", "date-time") => "DateTimeOffset",
                 ("string", "uuid") => "Guid",
                 ("string", _) => "string", // covers commonmark and html
                 ("number", "double" or "float" or "decimal") => format.ToLowerInvariant(),
                 ("number" or "integer", "int8") => "sbyte",
                 ("number" or "integer", "uint8") => "byte",
                 ("number" or "integer", "int64") => "int64",
                 ("number", "int32") => "integer",
@@ -1202,7 +1205,7 @@
             var suffix = $"{operationType}Response";
             var modelType = CreateModelDeclarations(currentNode, schema, operation, parentClass, suffix);
             if (modelType is not null && config.IncludeBackwardCompatible && config.Language is GenerationLanguage.CSharp or GenerationLanguage.Go && modelType.Name.EndsWith(suffix, StringComparison.Ordinal))
             { //TODO remove for v2
                 var obsoleteTypeName = modelType.Name[..^suffix.Length] + "Response";
                 if (modelType is CodeType codeType &&
                     codeType.TypeDefinition is CodeClass codeClass)
@@ -1335,7 +1338,7 @@
             executorMethod.AddParameter(cancellationParam);// Add cancellation token parameter
 
             if (returnTypes.Item2 is not null && config.IncludeBackwardCompatible)
             { //TODO remove for v2
                 var additionalExecutorMethod = (CodeMethod)executorMethod.Clone();
                 additionalExecutorMethod.ReturnType = returnTypes.Item2;
                 additionalExecutorMethod.OriginalMethod = executorMethod;
@@ -2393,7 +2396,7 @@
         if (!parameterClass.ContainsPropertyWithWireName(prop.WireName))
         {
             if (addBackwardCompatibleParameter && config.IncludeBackwardCompatible && config.Language is GenerationLanguage.CSharp or GenerationLanguage.Go)
             { //TODO remove for v2
                 var modernProp = (CodeProperty)prop.Clone();
                 modernProp.Name = $"{prop.Name}As{modernProp.Type.Name.ToFirstCharacterUpperCase()}";
                 modernProp.SerializationName = prop.WireName;

src/kiota/Handlers/BaseKiotaCommandHandler.cs

@@ -310,8 +310,8 @@ private static string GetSourceArg(string path, string manifest)
     }
     protected void DisplayUrlInformation(string? apiRootUrl, bool isPlugin = false)
     {
-        if (!string.IsNullOrEmpty(apiRootUrl))
-            DisplayInfo($"{(isPlugin ? "Plugin" : "Client")} base url set to {apiRootUrl}");
+        if (!string.IsNullOrEmpty(apiRootUrl) && !isPlugin)
+            DisplayInfo($"Client base url set to {apiRootUrl}");
     }
     protected void DisplayGenerateCommandHint()
     {

src/kiota/Handlers/Plugin/AddHandler.cs

@@ -75,7 +75,7 @@ public override async Task<int> InvokeAsync(InvocationContext context)
                 if (result)
                 {
                     DisplaySuccess("Generation completed successfully");
-                    DisplayUrlInformation(Configuration.Generation.ApiRootUrl);
+                    DisplayUrlInformation(Configuration.Generation.ApiRootUrl, true);
                 }
                 else if (skipGeneration)
                 {

src/kiota/Handlers/Plugin/EditHandler.cs

@@ -92,7 +92,7 @@ public override async Task<int> InvokeAsync(InvocationContext context)
                 if (result)
                 {
                     DisplaySuccess("Generation completed successfully");
-                    DisplayUrlInformation(Configuration.Generation.ApiRootUrl);
+                    DisplayUrlInformation(Configuration.Generation.ApiRootUrl, true);
                 }
                 else if (skipGeneration)
                 {