Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LINQ from generated code #4823

Merged
merged 7 commits into from
Jun 13, 2024
Merged

Remove LINQ from generated code #4823

merged 7 commits into from
Jun 13, 2024

Conversation

kasperk81
Copy link
Contributor

fix #4732

@kasperk81 kasperk81 requested a review from a team as a code owner June 13, 2024 07:46
@kasperk81
Copy link
Contributor Author

@baywet @andrueastman

andrueastman
andrueastman reviewed Jun 13, 2024
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance you can double check the failing tests?

Any chance you can submit a PR similar to microsoft/kiota-samples#5824 so as to update the samples as well?

baywet
baywet approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the hard work on this! Excited to see how much AOT apps and the Graph SDK are going to drop in size!

@andrueastman andrueastman merged commit c609889 into microsoft:main Jun 13, 2024
206 checks passed
@baywet baywet mentioned this pull request Jun 20, 2024
Merged
@baywet baywet mentioned this pull request Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@andrueastman andrueastman andrueastman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove LINQ usage from the generated code
3 participants
@kasperk81 @andrueastman @baywet